[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 25 16:07:45 UTC 2016


--- Comment #35 from Thomas J. Moore <darktjm at gmail.com> ---
(In reply to Mikhail Korolev from comment #33)
 > Your code calls dlsym at every call of glGetString/glXGetProcAddressARB
> instead of call it only at startup.

If so, your version of gcc is broken.  Just in case my gcc is broken as well, I
checked with gdb and the lines of code executing dlsym are executed exactly
once, while the wrappers themselves are called more than once.  The only error
I can see on reviewing my code is that I misspelled Enhanced, which is not
worth correcting.  That's not to say my code is perfect, though.

> Fix in attachments.

If you say so.  Thanks for trying, at least.  Seems more complex to me with
little benefit (the benefit being no longer executing the NULL check every
call, which probably takes a few nanoseconds).  In fact, using _init like that
makes me uncomfortable, since the time of symbol resolution is less obvious. 
If it works, it works, though.

(In reply to Mikhail Korolev from comment #33)
> As for vendor check location:

Thanks.  I guess what I really meant to say is that I no longer have the
patience and dedication needed to properly reverse engineer and provide patches
for the code.  Last time I did that was over 20 years ago

You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160725/a75cc1fc/attachment.html>

More information about the mesa-dev mailing list