On 22 July 2016 at 17:22, Rob Herring <robh at kernel.org> wrote: > /* Set functions. */ > - ws->base.unref = amdgpu_winsys_unref; With this in place we're NULL refer in the driver(s). Although you've removed the callers with next patch, IMHO it's worth adding a NULL check here ? -Emil