[Mesa-dev] [PATCH v4 09/11] vmwgfx: use common screen ref counting

Emil Velikov emil.l.velikov at gmail.com
Tue Jul 26 10:06:01 UTC 2016

On 26 July 2016 at 10:59, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 22 July 2016 at 17:22, Rob Herring <robh at kernel.org> wrote:
>> @@ -100,11 +72,8 @@ vmw_winsys_create( int fd )
>>     if (!vmw_winsys_screen_init_svga(vws))
>>        goto out_no_svga;
>> -   if (util_hash_table_set(dev_hash, &vws->device, vws) != PIPE_OK)
>> -      goto out_no_hash_insert;
>> -
> Any reason why you didn't call pipe_screen_reference_init() here but
> you've moved in the driver ?
Grr just hit me - because unlike other drivers svga does not call
screen_create in it's winsys. Other drivers did that to reuse the
locking for both fd and screen management, but with the separate locks
introduced in the series things should be great.

In theory one could 'decouple' the radeon/amdgpu/nouvea... winsys and
drivers, just like svga. If they're interested/see value in it.


More information about the mesa-dev mailing list