[Mesa-dev] [PATCH v4 01/11] gallium: move pipe_screen destroy into pipe-loader

[Rob Herring]

On Tue, Jul 26, 2016 at 4:15 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 22 July 2016 at 17:22, Rob Herring <robh at kernel.org> wrote:
>> In preparation to add reference counting of pipe_screen in the pipe-loader,
>> pipe_loader_release needs to destroy the pipe_screen instead of state
>> trackers.
>>
>> Signed-off-by: Rob Herring <robh at kernel.org>
>> Cc: Emil Velikov <emil.l.velikov at gmail.com>
>
>> --- a/src/gallium/state_trackers/clover/core/device.cpp
>> +++ b/src/gallium/state_trackers/clover/core/device.cpp
>> @@ -45,14 +45,12 @@ device::device(clover::platform &platform, pipe_loader_device *ldev) :
>>     pipe = pipe_loader_create_screen(ldev);
>>     if (!pipe || !pipe->get_param(pipe, PIPE_CAP_COMPUTE)) {
>>        if (pipe)
>> -         pipe->destroy(pipe);
>> +         pipe_loader_release(&ldev, 1);
> My C++ is a bit rusty - are we going to end up using device::ldev here
> or the one provided by the user ?

I believe this->ldev would be device::ldev and this is the parameter
ldev. Probably would be best to rename one of them.

Rob