[Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not follow the push path for indexed draws

[Ilia Mirkin]

On Wed, Jul 27, 2016 at 9:42 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 8 June 2016 at 18:08, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
>> This fixes a lot of flickering in The Talos Principle on Fermi+
>> (tested on both GF119 and GK106). My guess is that some indices
>> and/or some vertex attributes are incorrectly set when emitting
>> data directly into the command stream rather than uploading a
>> user VBO.
>>
>> The NV50 driver also doesn't use the push path for indexed draws
>> which makes confident enough with this fix. Furthermore, this
>> doesn't introduce any regressions with piglit.
>>
>> As a side-effect, this also improves performance with The Talos
>> Principle (+~20% fps) and probably with other games which use indexed
>> draws. This is because uploading a user VBO is more efficient than
>> pushing data directly into the pushbuf.
>>
>> There is still an issue in this game (sometimes walls become green),
>> but this seems to be totally unrelated to the first issue (disabling
>> the push path doesn't help here).
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90513
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> CC: "11.1 11.2" <mesa-stable at lists.freedesktop.org>
> Gents, this patch can be considered superseded in favour of
> 154c0a42a23187c61ea0a1307198fae667398eba, correct ?

Correct.