[Mesa-dev] [PATCH v4 1/2] glx: fix error code when there is no context bound

Tapani Pälli tapani.palli at intel.com
Wed Jul 27 13:55:35 UTC 2016


On 07/27/2016 04:53 PM, Emil Velikov wrote:
> On 14 June 2016 at 16:08, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> n 7 June 2016 at 11:33, Tapani Pälli <tapani.palli at intel.com> wrote:
>>> From: Bernard Kilarski <bernard.r.kilarski at intel.com>
>>>
>>> v2: change all related NULL checks to check against dummyContext
>>> v3: really check for dummyContext *only* when ctx was from
>>>      __glXGetCurrentContext
>>> v4: cover more checks, add dummyBuffer, dummyVtable (Emil)
>>>
>> Thanks for the update Tapani. There's a minor comment below, but
>> regardless if you go for it or not the patch is
>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>>
>>> +GLubyte dummyBuffer[__GLX_BUFFER_LIMIT_SIZE];
>>> +struct glx_context_vtable dummyVtable;
>> Make these two static ?
>>
> AFAICT the patch hasn't landed in master. Tapani is there something
> wrong with it and/or fall through the cracks ?

I was hoping to push both patches at once. I asked Jeremy to test the 
Apple specific one:

https://lists.freedesktop.org/archives/mesa-dev/2016-July/123436.html


> Thanks
> Emil


// Tapani




More information about the mesa-dev mailing list