[Mesa-dev] [PATCH] ddebug: use pclose to close a popen()'d FILE

Marek Olšák maraeo at gmail.com
Wed Jul 27 22:39:34 UTC 2016


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Wed, Jul 27, 2016 at 4:48 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
> Found by Coverity.
> ---
>  src/gallium/drivers/ddebug/dd_draw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c
> index a54cecb..d3c4e7f 100644
> --- a/src/gallium/drivers/ddebug/dd_draw.c
> +++ b/src/gallium/drivers/ddebug/dd_draw.c
> @@ -70,7 +70,7 @@ dd_dump_dmesg(FILE *f)
>     while (fgets(line, sizeof(line), p))
>        fputs(line, f);
>
> -   fclose(p);
> +   pclose(p);
>  }
>
>  static void
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list