[Mesa-dev] [PATCH v2 20/35] i965/blorp: Get rid of brw_blorp_surface_info::width/height

[Pohjolainen, Topi]

On Tue, Jul 26, 2016 at 03:02:11PM -0700, Jason Ekstrand wrote:
> Instead, we manually mutate the surface size as needed.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c        | 21 ++++++---------------
>  src/mesa/drivers/dri/i965/brw_blorp.h        | 12 ------------
>  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 19 +++++++++++++++----
>  src/mesa/drivers/dri/i965/gen6_blorp.c       |  4 ++--
>  src/mesa/drivers/dri/i965/gen7_blorp.c       |  4 ++--
>  5 files changed, 25 insertions(+), 35 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 8ccb8da..78707ca 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -203,8 +203,6 @@ brw_blorp_surface_info_init(struct brw_context *brw,
>  
>     info->level = level;
>     info->layer = layer;
> -   info->width = minify(mt->physical_width0, level - mt->first_level);
> -   info->height = minify(mt->physical_height0, level - mt->first_level);
>  
>     if (format == MESA_FORMAT_NONE)
>        format = mt->format;
> @@ -373,10 +371,6 @@ brw_blorp_emit_surface_state(struct brw_context *brw,
>  
>     struct isl_surf surf = surface->surf;
>  
> -   /* Stomp surface dimensions and tiling (if needed) with info from blorp */
> -   surf.logical_level0_px.width = surface->width;
> -   surf.logical_level0_px.height = surface->height;

Like I commented in the previous patch, I thought this is needed already
there. I'm probably missing something...