[Mesa-dev] [PATCH 3/3] anv/x11: Destroy Present event context when destroying swapchain

Michel Dänzer michel at daenzer.net
Thu Jul 28 09:34:46 UTC 2016


From: Michel Dänzer <michel.daenzer at amd.com>

Without this, the X server may accumulate stale Present event contexts
if a client creates and destroys multiple swapchains using the same
window.

Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---

NOTE: This patch is completely untested! Ideally, somebody working on
      this code can review, test and push it.

 src/intel/vulkan/anv_wsi_x11.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/intel/vulkan/anv_wsi_x11.c b/src/intel/vulkan/anv_wsi_x11.c
index 2895d6b..610628a 100644
--- a/src/intel/vulkan/anv_wsi_x11.c
+++ b/src/intel/vulkan/anv_wsi_x11.c
@@ -734,11 +734,16 @@ x11_swapchain_destroy(struct anv_swapchain *anv_chain,
                       const VkAllocationCallbacks *pAllocator)
 {
    struct x11_swapchain *chain = (struct x11_swapchain *)anv_chain;
+   xcb_void_cookie_t cookie;
 
    for (uint32_t i = 0; i < chain->image_count; i++)
       x11_image_finish(chain, pAllocator, &chain->images[i]);
 
    xcb_unregister_for_special_event(chain->conn, chain->special_event);
+   cookie = xcb_present_select_input(chain->conn, chain->event_id,
+                                     chain->window,
+                                     XCB_PRESENT_EVENT_MASK_NO_EVENT);
+   free(xcb_check_request(chain->conn, cookie));
 
    anv_free2(&chain->base.device->alloc, pAllocator, chain);
 
-- 
2.8.1



More information about the mesa-dev mailing list