[Mesa-dev] [PATCH v2 30/35] isl: Add asserts for gen8+ X/YOffset rules

Pohjolainen, Topi topi.pohjolainen at intel.com
Thu Jul 28 13:02:13 UTC 2016


On Tue, Jul 26, 2016 at 03:02:21PM -0700, Jason Ekstrand wrote:
> ---
>  src/intel/isl/isl_surface_state.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
> index 6febcbf..fb23414 100644
> --- a/src/intel/isl/isl_surface_state.c
> +++ b/src/intel/isl/isl_surface_state.c
> @@ -414,6 +414,16 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
>        assert(info->surf->levels == 1);
>        assert(info->surf->logical_level0_px.array_len == 1);
>        assert(info->aux_usage == ISL_AUX_USAGE_NONE);
> +
> +      if (GEN_GEN >= 8) {
> +         /* Broadwell added more rules. */
> +         assert(info->surf->samples == 1);
> +         if (isl_format_get_layout(info->view->format)->bpb == 8)
> +            assert(info->x_offset_sa % 16 == 0);

Should this go below and the one there up here?

> +         if (isl_format_get_layout(info->view->format)->bpb == 16)
> +            assert(info->x_offset_sa % 8 == 0);
> +      }
> +
>  #if GEN_GEN >= 7
>        s.SurfaceArray = false;
>  #endif
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list