[Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader
Anuj Phogat
anuj.phogat at gmail.com
Thu Jul 28 18:30:40 UTC 2016
We should use the persample_dispatch variable in prog_data.
Fixes all (~60) the DEQP sample shading tests. Many tests exited with
VK_ERROR_OUT_OF_DEVICE_MEMORY without this patch.
V2: Use the shader key bits set in brw_compile_fs (Jason)
Cc: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
---
src/intel/vulkan/gen8_pipeline.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c
index cc10d3a..67ffca6 100644
--- a/src/intel/vulkan/gen8_pipeline.c
+++ b/src/intel/vulkan/gen8_pipeline.c
@@ -365,16 +365,13 @@ genX(graphics_pipeline_create)(
wm_prog_data->dispatch_grf_start_reg_2;
}
- bool per_sample_ps = pCreateInfo->pMultisampleState &&
- pCreateInfo->pMultisampleState->sampleShadingEnable;
-
anv_batch_emit(&pipeline->batch, GENX(3DSTATE_PS_EXTRA), ps) {
ps.PixelShaderValid = true;
ps.PixelShaderKillsPixel = wm_prog_data->uses_kill;
ps.PixelShaderComputedDepthMode = wm_prog_data->computed_depth_mode;
ps.AttributeEnable = wm_prog_data->num_varying_inputs > 0;
ps.oMaskPresenttoRenderTarget = wm_prog_data->uses_omask;
- ps.PixelShaderIsPerSample = per_sample_ps;
+ ps.PixelShaderIsPerSample = wm_prog_data->persample_dispatch;
ps.PixelShaderUsesSourceDepth = wm_prog_data->uses_src_depth;
ps.PixelShaderUsesSourceW = wm_prog_data->uses_src_w;
#if GEN_GEN >= 9
--
2.5.5
More information about the mesa-dev
mailing list