[Mesa-dev] [PATCH 2/2] anv: Enable per sample shading on gen8+

Jason Ekstrand jason at jlekstrand.net
Thu Jul 28 18:58:54 UTC 2016


Rb

On Jul 28, 2016 1:31 PM, "Anuj Phogat" <anuj.phogat at gmail.com> wrote:

> Vulkan CTS test results on gen9:
> ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.min_sample_shading*
> Test run totals:
>   Passed:        60/90 (66.7%)
>   Failed:        0/90 (0.0%)
>   Not supported: 30/90 (33.3%)
>   Warnings:      0/90 (0.0%)
>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/intel/vulkan/anv_device.c    | 2 +-
>  src/intel/vulkan/gen8_pipeline.c | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 2e91980..c2c5153 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -375,7 +375,7 @@ void anv_GetPhysicalDeviceFeatures(
>        .independentBlend                         = true,
>        .geometryShader                           = true,
>        .tessellationShader                       = false,
> -      .sampleRateShading                        = false,
> +      .sampleRateShading                        = pdevice->info->gen >= 8,
>        .dualSrcBlend                             = true,
>        .logicOp                                  = true,
>        .multiDrawIndirect                        = false,
> diff --git a/src/intel/vulkan/gen8_pipeline.c
> b/src/intel/vulkan/gen8_pipeline.c
> index 67ffca6..94f50d1 100644
> --- a/src/intel/vulkan/gen8_pipeline.c
> +++ b/src/intel/vulkan/gen8_pipeline.c
> @@ -122,9 +122,6 @@ emit_ms_state(struct anv_pipeline *pipeline,
>     if (info && info->pSampleMask)
>        sample_mask &= info->pSampleMask[0];
>
> -   if (info && info->sampleShadingEnable)
> -
> anv_finishme("VkPipelineMultisampleStateCreateInfo::sampleShadingEnable");
> -
>     anv_batch_emit(&pipeline->batch, GENX(3DSTATE_MULTISAMPLE), ms) {
>        /* The PRM says that this bit is valid only for DX9:
>         *
> --
> 2.5.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160728/26520ec5/attachment.html>


More information about the mesa-dev mailing list