[Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

[Francesco Ansanelli]

I did a test with:

static struct ir3_shader_key key;
memset(&key, 0, sizeof(key));

both gcc and clang seems happy with it.
Let me know if you want me to send a patch.


2016-07-29 1:53 GMT+02:00 Rob Clark <robdclark at gmail.com>:

> On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring <robh at kernel.org> wrote:
> > On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark <robdclark at gmail.com> wrote:
> >> tbh, I haven't used anything as ancient as 4.6 in a while.. these days
> >> I'm using 6.1 and even with 5.x I don't remember seeing that warning.
> >
> > FWIW, clang 3.8 throws the warning too.
> >
>
> I think that since it is only that one spot (which, btw, is only hit
> w/ FD_MESA_DEBUG=shaderdb, ie. only for running shaderdb tests), we
> could also go old-school and just memset() it..
>
> BR,
> -R
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160729/3825a665/attachment.html>