[Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

[Roland Scheidegger]

This looks very bogus to me.
How is this supposed to work if you immediately close the library again?
The functions are still going to get used.
This just segfaults right, left and center.

If you want to fix this for real, some util_format_s3tc_exit() is
probably needed, albeit I'm not entirely sure it can be made to work
reliably (not just drivers, but the dri state tracker calls this too.

In any case, I'm going to revert it.

Roland


Am 30.07.2016 um 17:28 schrieb Marek Olšák:
> Pushed, thanks.
> 
> Marek
> 
> On Sat, Jul 30, 2016 at 2:35 AM, Eric Engestrom <eric at engestrom.ch> wrote:
>> CovID: 401540
>> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
>> ---
>>  src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c
>> index 8c4f215..1ed4336 100644
>> --- a/src/gallium/auxiliary/util/u_format_s3tc.c
>> +++ b/src/gallium/auxiliary/util/u_format_s3tc.c
>> @@ -157,6 +157,8 @@ util_format_s3tc_init(void)
>>     util_format_dxt5_rgba_fetch = (util_format_dxtn_fetch_t)fetch_2d_texel_rgba_dxt5;
>>     util_format_dxtn_pack = (util_format_dxtn_pack_t)tx_compress_dxtn;
>>     util_format_s3tc_enabled = TRUE;
>> +
>> +   util_dl_close(library);
>>  }
>>
>>
>> --
>> 2.9.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=Cu9I_ewyH3ywgtJw3yZgTOf08y5vGdy69Z6sYSoinRg&s=LmaeyWjVZByKWxP-aY6hMpUEK6RLw53i4Bke5qBi3JI&e= 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=Cu9I_ewyH3ywgtJw3yZgTOf08y5vGdy69Z6sYSoinRg&s=LmaeyWjVZByKWxP-aY6hMpUEK6RLw53i4Bke5qBi3JI&e= 
>