[Mesa-dev] [PATCH 00/65] ARB_internalformat_query2 support for Mesa and i965

[Alejandro Piñeiro]

On 02/03/16 02:04, Dave Airlie wrote:
> On 2 March 2016 at 10:49, Dave Airlie <airlied at gmail.com> wrote:
>> On 1 March 2016 at 19:04, Eduardo Lima Mitev <elima at igalia.com> wrote:
>>> Hi,
>>>
>>> I have sent updates for some of the patches, fixing a few dEQP regressions
>>> we found, as well as rebase conflicts.
>>>
>>> At this point, we don't have a any piglit or dEQP regression (GLES3 or
>>> GLES31).
>>>
>>> I was wondering if we maybe split the series in smaller sets, it would help
>>> review. Like for example, a first set only introducing the new driver hook
>>> to query1, then another set with query2 stuff, then the i965 bits.
>>>
>>> Would that help?
>> Possibly, though I'm going to see what I can get through, though it
>> might be lots of passing replies in comments rather than a coherent
>> review at this stage:
>>
>> Do you handle:
>>
>> Dependencies on OpenGL 3.2 (Core Profile)
>>     In core profiles for OpenGL 3.2 and later versions, queries
>>     for the AUTO_GENERATE_MIPMAP <pname> return the appropriate
>>     unsupported response.
>>
>> I'm not seeing special case code for that.
> One thing I think would be really useful but might be outside the scope
> of your work is a mesa-demos glxinfo super query app.
>
> Something that does what vulkaninfo kinda does and dumps out the
> results of every possible query for every possibly GL format.

At some point of the development of the piglit tests for this spec, I
had a dummy test that printed the outcome of a given pname for every
possible target/internalformat. I used it to compare the outcome of
proprietary drivers against our wip implementation, as a reference. It
would not be so complex to bring it back, and iterate for all the
pnames. Having said so, that is somewhat easier on piglit due all the
utility methods behind. Probably on mesa-demos I would need to do some
extra work.

> Feel free to tell me I'm dreaming.

I think that at least I will take a look to see how much effort would be
needed to port that piglit fake test to mesa-demos.

BR