[Mesa-dev] [PATCH 2/2] mesa: Allow Get*() of several forgotten IsEnabled() pnames.

[Ilia Mirkin]

On Thu, Mar 3, 2016 at 4:27 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> From section 6.2 ("State Tables") of the GL 2.1 specification
> (the text also appears in the GL 3.0 and ES 3.1 specifications):
> "However, state variables for which IsEnabled is listed as the query
>  command can also be obtained using GetBooleanv, GetIntegerv, GetFloatv,
>  and GetDoublev."

I never saw this text and was assuming that the dEQP tests were wrong.
Nicely found. This series is

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

>
> GL_DEBUG_OUTPUT, GL_DEBUG_OUTPUT_SYNCHRONOUS, and GL_FRAGMENT_SHADER_ATI
> were missing from the glGet*() functions.  All other IsEnabled() pnames
> look to be present, as far as I can tell.
>
> Fixes 8 dEQP-GLES31.functional.debug.state_query subtests:
> debug_output[_synchronous]_get{boolean,float,integer,integer64}.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/get.c              | 2 ++
>  src/mesa/main/get_hash_params.py | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index f40c570..4cc82d8 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -1055,6 +1055,8 @@ find_custom_value(struct gl_context *ctx, const struct value_desc *d, union valu
>        }
>        break;
>     /* GL_KHR_DEBUG */
> +   case GL_DEBUG_OUTPUT:
> +   case GL_DEBUG_OUTPUT_SYNCHRONOUS:
>     case GL_DEBUG_LOGGED_MESSAGES:
>     case GL_DEBUG_NEXT_LOGGED_MESSAGE_LENGTH:
>     case GL_DEBUG_GROUP_STACK_DEPTH:
> diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
> index 07d2d20..f9d66f8 100644
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -126,6 +126,8 @@ descriptor=[
>    [ "MAX_TEXTURE_MAX_ANISOTROPY_EXT", "CONTEXT_FLOAT(Const.MaxTextureMaxAnisotropy), extra_EXT_texture_filter_anisotropic" ],
>
>  # GL_KHR_debug (GL 4.3)/ GL_ARB_debug_output
> +  [ "DEBUG_OUTPUT", "LOC_CUSTOM, TYPE_BOOLEAN, 0, NO_EXTRA" ],
> +  [ "DEBUG_OUTPUT_SYNCHRONOUS", "LOC_CUSTOM, TYPE_BOOLEAN, 0, NO_EXTRA" ],
>    [ "DEBUG_LOGGED_MESSAGES", "LOC_CUSTOM, TYPE_INT, 0, NO_EXTRA" ],
>    [ "DEBUG_NEXT_LOGGED_MESSAGE_LENGTH", "LOC_CUSTOM, TYPE_INT, 0, NO_EXTRA" ],
>    [ "MAX_DEBUG_LOGGED_MESSAGES", "CONST(MAX_DEBUG_LOGGED_MESSAGES), NO_EXTRA" ],
> @@ -773,6 +775,7 @@ descriptor=[
>    [ "DEPTH_CLAMP", "CONTEXT_BOOL(Transform.DepthClamp), extra_ARB_depth_clamp" ],
>
>  # GL_ATI_fragment_shader
> +  [ "FRAGMENT_SHADER_ATI", "CONTEXT_BOOL(ATIFragmentShader.Enabled), extra_ATI_fragment_shader" ],
>    [ "NUM_FRAGMENT_REGISTERS_ATI", "CONST(6), extra_ATI_fragment_shader" ],
>    [ "NUM_FRAGMENT_CONSTANTS_ATI", "CONST(8), extra_ATI_fragment_shader" ],
>    [ "NUM_PASSES_ATI", "CONST(2), extra_ATI_fragment_shader" ],
> --
> 2.7.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev