[Mesa-dev] i965 geom shader dual object fail

[Dave Airlie]

On 4 March 2016 at 11:49, Dave Airlie <airlied at gmail.com> wrote:
> So this came up with virgl, after I fixed some other stupidity (there
> may still be some), but it provoked some questions.
>
> In brw_vec4_gs_visitor.cpp the dual object code builds a visitor and
> runs it. If the run fails then it goes and compiles in single object
> mode.
>
> Now we pass prog_data into the first pass, and it seems to modify
> nr_params, then when the second pass goes to run it gets the wrong
> number of uniforms and asserts in the middle. Should something be
> saving some values and restoring them here, or undoing something from
> the visitor code?

Here's a horrible demonstration patch that seems to work.

Dave.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-i965-gs-backup-prog-data-around-first-attempt-at-com.patch
Type: text/x-patch
Size: 1623 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160304/6d97eba0/attachment.bin>