[Mesa-dev] [PATCH 2/2] mesa: Allow Get*() of several forgotten IsEnabled() pnames.

[Kenneth Graunke]

On Thursday, March 3, 2016 9:44:43 PM PST Emil Velikov wrote:
> On 3 March 2016 at 09:27, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > From section 6.2 ("State Tables") of the GL 2.1 specification
> > (the text also appears in the GL 3.0 and ES 3.1 specifications):
> > "However, state variables for which IsEnabled is listed as the query
> >  command can also be obtained using GetBooleanv, GetIntegerv, GetFloatv,
> >  and GetDoublev."
> >
> > GL_DEBUG_OUTPUT, GL_DEBUG_OUTPUT_SYNCHRONOUS, and GL_FRAGMENT_SHADER_ATI
> Out of curiosity - how did you spot the missing FRAGMENT_SHADER_ATI ?

I pulled all the "case GL_WHATEVER:" enums from _mesa_IsEnabled() into
a file, and then ran

for ENUM in $(grep case isenablecases | cut -c 15- | sed 's/:.*$//g' | sed 's/
_EXT$//g' | sed 's/_ARB$//g'); do grep -q "\"$ENUM" get_hash_params.py || echo 
"$ENUM missing"; done

which isn't fool-proof, but was good enough to spot this one.

> 
> > were missing from the glGet*() functions.  All other IsEnabled() pnames
> > look to be present, as far as I can tell.
> >
> > Fixes 8 dEQP-GLES31.functional.debug.state_query subtests:
> > debug_output[_synchronous]_get{boolean,float,integer,integer64}.
> >
> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Nicely spotted Ken. For the series
> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Feel free to tag them for stable.
> 
> Thanks
> Emil

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160303/e04cfd97/attachment.sig>