[Mesa-dev] [PATCH] gallium/swr: fix issues preventing 32-bit build

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 4 21:26:55 UTC 2016


Hi Tim,

On 4 March 2016 at 19:28, Tim Rowley <timothy.o.rowley at intel.com> wrote:
> Not a currently tested configuration, but these couple of small changes
> allow a 32-bit build.
A couple of trivial suggestions:

Please add the bugzilla link, before pushing.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94383

> ---
>  src/gallium/drivers/swr/rasterizer/common/os.h  | 1 -
>  src/gallium/drivers/swr/rasterizer/core/utils.h | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h
> index 736d298..522ae0d 100644
> --- a/src/gallium/drivers/swr/rasterizer/common/os.h
> +++ b/src/gallium/drivers/swr/rasterizer/common/os.h
> @@ -81,7 +81,6 @@ typedef CARD8                 BOOL;
>  typedef wchar_t                        WCHAR;
>  typedef uint16_t               UINT16;
>  typedef int                            INT;
> -typedef int             INT32;
>  typedef unsigned int   UINT;
>  typedef uint32_t               UINT32;
>  typedef uint64_t               UINT64;
If you can remove this abstraction and use plain C types that will be
amazing. With future commits of course.

For the patch:
Acked-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
Emil


More information about the mesa-dev mailing list