[Mesa-dev] [PATCH v2] st/mesa: don't force per-sample interp if only sampleid/pos are used

[Marek Olšák]

On Fri, Mar 4, 2016 at 7:13 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Fri, Mar 4, 2016 at 12:26 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> The OES extensions clarify this behaviour to differentiate between
>> per-sample invocation and per-sample interpolation. Using sampleid/pos
>> will force per-sample invocation but not per-sample interpolation.
>>
>> See https://www.khronos.org/bugzilla/show_bug.cgi?id=1462
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Reviewed-by: Marek Olšák <marek.olsak at amd.com> (v1)
>>
>> v1 -> v2:
>>   set key.persample_shading in the same way as raster->force_persample_interp
>>   except with an inverted dep on st->force_persample_in_shader
>> ---
>>
>> I realized that my old method would end up setting key.persample_shading when
>> the shader used sample id/sample pos. Rather than futz around with the
>> condition or add more helpers, this just reuses the current logic for setting
>> raster->force_persample_interp but flips the dependency on whether it has to be
>> done by hand or not. (And uses the semi-new mesa_geometric_samples helper.)
>
> And naturally I was too eager to send this out... minor compile fixes
> folded in here:
>
> https://github.com/imirkin/mesa/commit/2c4f19554adc5e9d7bea1164169381184eac50e1
>
> Didn't think it was worth resending.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek