[Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

[Oded Gabbay]

On Mar 6, 2016 2:26 PM, "Marek Olšák" <maraeo at gmail.com> wrote:
>
> Hi Oded,
>
> I prefer "if" over #ifdef. The idea is that everybody should be able
> to test if the compilation succeeds without a BE machine. #ifdef
> disallows that.
>
> R600_BIG_ENDIAN can be moved to r600_pipe_common.h.
>
> Marek
>
OK, no problem.
I'll move the define as part of the next patch set I'll send.
Oded

>
> On Sun, Mar 6, 2016 at 9:01 AM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
> > Hi,
> >
> > Do you mind if I totally remove R600_BIG_ENDIAN global variable and
> > instead use in all places #ifdef PIPE_ARCH_BIG_ENDIAN ?
> >
> > It's just that:
> >
> > 1. Checking for R600_BIG_ENDIAN is an extra check which can be
> > eliminated using #ifdef
> >
> > 2. Some files, e.g r600_texture.c, don't know R600_BIG_ENDIAN so I
> > need to use the #ifdef anyway.
> >
> > 3. Other drivers in mesa use #ifdef
> >
> > Thanks,
> >
> >      Oded
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160307/7bb49709/attachment.html>