[Mesa-dev] [PATCH] mesa: Make glGetInteger64v convert float/doubles to 32-bit integers.

[Dave Airlie]

On 9 March 2016 at 15:42, Kenneth Graunke <kenneth at whitecape.org> wrote:
> According to the GL 4.4 core specification, section 2.2.2 ("Data
> Conversions For State Query Commands"):
>
> "If a command returning integer data is called, such as GetIntegerv or
>  GetInteger64v, a boolean value of TRUE or FALSE is interpreted as one
>  or zero, respectively. A floating-point value is rounded to the nearest
>  integer, unless the value is an RGBA color component, a DepthRange
>  value, or a depth buffer clear value. In these cases, the query command
>  converts the floating-point value to an integer according to the INT
>  entry of table 18.2; a value not in [−1, 1] converts to an undefined
>  value."
>
> The INT entry of table 18.2 shows that b = 32, meaning the expectation
> is to convert it to a 32-bit integer value.
>
> Fixes:
> dEQP-GLES3.functional.state_query.floats.blend_color_getinteger64
> dEQP-GLES3.functional.state_query.floats.color_clear_value_getinteger64
> dEQP-GLES3.functional.state_query.floats.depth_clear_value_getinteger64
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94456
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Make sense to me.

Reviewed-by: Dave Airlie <airlied at redhat.com>