[Mesa-dev] [PATCH] i965/cfg: Remove redundant #pragma once.

Matt Turner mattst88 at gmail.com
Thu Mar 10 02:27:37 UTC 2016


On Wed, Mar 9, 2016 at 1:37 PM, Francisco Jerez <currojerez at riseup.net> wrote:
> Iago Toral <itoral at igalia.com> writes:
>
>> On Tue, 2016-03-08 at 17:42 -0800, Francisco Jerez wrote:
>>> brw_cfg.h already has include guards, remove the "#pragma once" which
>>> is redundant and non-standard.
>>
>> FWIW, I think using both #pragma once and include guards is a way to
>> keep portability while still getting the performance advantage of
>> #pragma once where it is supported.
>>
> It's highly unlikely to make any significant difference on any
> reasonably modern compiler.  I cannot measure any change in compilation
> time locally from my cleanup.
>
>> Also it seems that we do the same thing in many other files...
>>
> Really?  I'm not aware of any other file where we use both.

There are quite a few in glsl/


More information about the mesa-dev mailing list