[Mesa-dev] [PATCH] mesa: Fix error condition for 1d array texture

[Alejandro Piñeiro]

On 11/03/16 20:15, Anuj Phogat wrote:
> yoffset is also applicable to 1d array textures.
>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
> I don't know if it fixes any test, but it looked incorrect to me.

No one fixed doing a piglit all.py run (also no regression). Didn't test
with a deqp run.

In any case, I also agree that the change seems to make sense.

>
>  src/mesa/main/texgetimage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
> index 06bc8f1..dc21551 100644
> --- a/src/mesa/main/texgetimage.c
> +++ b/src/mesa/main/texgetimage.c
> @@ -1046,7 +1046,7 @@ dimensions_error_check(struct gl_context *ctx,
>                          "%s(xoffset = %d)", caller, xoffset);
>              return true;
>           }
> -         if (target != GL_TEXTURE_1D && target != GL_TEXTURE_1D_ARRAY) {
> +         if (target != GL_TEXTURE_1D) {
>              if (yoffset % bh != 0) {
>                 _mesa_error(ctx, GL_INVALID_VALUE,
>                             "%s(yoffset = %d)", caller, yoffset);

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>