[Mesa-dev] [PATCH] swrast: Delete the unused 'slice' parameter

[Anuj Phogat]

On Sat, Mar 12, 2016 at 1:42 AM, Alejandro Piñeiro <apinheiro at igalia.com>
wrote:

> On 12/03/16 00:16, Anuj Phogat wrote:
> > Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>
> Any reason to not just move the slice assert at line 243 as part of the
> checks of check_map_teximage?
>
Didn't notice it. I'll take your suggestion and send out a separate patch.
Dropping this one.


>
> > ---
> >  src/mesa/swrast/s_texture.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c
> > index 9ccd0e3..6ea7b6c 100644
> > --- a/src/mesa/swrast/s_texture.c
> > +++ b/src/mesa/swrast/s_texture.c
> > @@ -178,7 +178,7 @@ _swrast_free_texture_image_buffer(struct gl_context
> *ctx,
> >   */
> >  static void
> >  check_map_teximage(const struct gl_texture_image *texImage,
> > -                   GLuint slice, GLuint x, GLuint y, GLuint w, GLuint h)
> > +                   GLuint x, GLuint y, GLuint w, GLuint h)
> >  {
> >
> >     if (texImage->TexObject->Target == GL_TEXTURE_1D)
> > @@ -216,7 +216,7 @@ _swrast_map_teximage(struct gl_context *ctx,
> >     GLint stride, texelSize;
> >     GLuint bw, bh;
> >
> > -   check_map_teximage(texImage, slice, x, y, w, h);
> > +   check_map_teximage(texImage, x, y, w, h);
> >
> >     if (!swImage->Buffer) {
> >        /* Either glTexImage was called with a NULL <pixels> argument or
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160314/5b1d3b49/attachment.html>