[Mesa-dev] [Bug 94549] [swrast] piglit glsl-arb-fragment-coord-conventions regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94549

            Bug ID: 94549
           Summary: [swrast] piglit glsl-arb-fragment-coord-conventions
                    regression
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: vlee at freedesktop.org
        QA Contact: mesa-dev at lists.freedesktop.org
                CC: imirkin at alum.mit.edu, lemody at gmail.com,
                    plamena.manolova at intel.com

mesa: 4de25fa7b050a296b2f1a4504e568dfce5d0a295 (master 11.3.0-devel)

$ ./bin/glsl-arb-fragment-coord-conventions -auto
Regular gl_FragCoord
Failed to link: error: count of uniform locations >
MAX_UNIFORM_LOCATIONS(4294967295 > 98304)
Probe color at (0,0)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (99,99)
  Expected: 1.000000 1.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Pixel center half integer
Failed to link: error: count of uniform locations >
MAX_UNIFORM_LOCATIONS(4294967295 > 98304)
Probe color at (0,0)
  Expected: 0.750000 0.750000 0.500000
  Observed: 1.000000 1.000000 1.000000
Probe color at (99,99)
  Expected: 0.750000 0.750000 1.000000
  Observed: 1.000000 1.000000 1.000000
Pixel center integer
Failed to link: error: count of uniform locations >
MAX_UNIFORM_LOCATIONS(4294967295 > 98304)
Probe color at (0,0)
  Expected: 0.250000 0.250000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (99,99)
  Expected: 0.250000 0.250000 1.000000
  Observed: 1.000000 1.000000 1.000000
Pixel origin upper left
Failed to link: error: count of uniform locations >
MAX_UNIFORM_LOCATIONS(4294967295 > 98304)
Probe color at (0,60)
  Expected: 0.000000 1.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (99,159)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Pixel origin upper left and pixel center integer
Failed to link: error: count of uniform locations >
MAX_UNIFORM_LOCATIONS(4294967295 > 98304)
Probe color at (0,60)
  Expected: 0.125000 0.372500 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (99,159)
  Expected: 0.372500 0.125000 0.000000
  Observed: 1.000000 1.000000 1.000000
PIGLIT: {"result": "fail" }

65dfb3048e8291675ca33581aeff8921f7ea509d is the first bad commit
commit 65dfb3048e8291675ca33581aeff8921f7ea509d
Author: Plamena Manolova <plamena.manolova at intel.com>
Date:   Thu Feb 11 15:00:02 2016 +0200

    compiler/glsl: Fix uniform location counting.

    This patch moves the calculation of current uniforms to
    link_uniforms, which makes use of UniformRemapTable which
    stores all the reserved uniform locations.

    Location assignment for implicit uniforms now tries to use
    any gaps left in the table after the location assignment
    for explicit uniforms. This gives us more space to store more
    uniforms.

    Patch is based on earlier patch with following changes/additions:

       1: Move the counting of explicit locations to
          check_explicit_uniform_locations and then pass
          the number to link_assign_uniform_locations.
       2: Count the number of empty slots in UniformRemapTable
          and store them in a list_head.
       3: Try to find an empty slot for implicit locations from
          the list, if that fails resize UniformRemapTable.

    Fixes following CTS tests:
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max
      
ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696

:040000 040000 5848c556c369c2c798c1c1e036c70c740b56a97a
25915fac71a54954aafd0139a55045ba394969e6 M    src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160315/c8fbfa5f/attachment.html>