[Mesa-dev] [PATCH v2] st/mesa: honour sized internal formats in st_choose_format (v2)

[Marek Olšák]

On Tue, Mar 15, 2016 at 3:53 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>
> On Mar 15, 2016 7:23 AM, "Nicolai Hähnle" <nhaehnle at gmail.com> wrote:
>>
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> The bitcasting which is possible with shader images (and texture views?)
>> requires that when the user specifies a sized internal format for a
>> texture, we really allocate that format. To this end:
>>
>> (1) find_exact_format should ignore sized internal formats and
>>
>> (2) some of the entries in the mapping table corresponding to sized
>>     internal formats are reordered to use an RGBA format instead of
>>     a BGRA one.
>>
>> This fixes arb_shader_image_load_store-bitcast in the (work in progress)
>> ARB_shader_image_load_store implementation for radeonsi.
>>
>> v2: don't change the mapping of GL_RGB10: the change caused a regression
>>     because it preferred a format with an alpha channel, and GL_RGB10
>>     is not among the supported formats for shader images
>
> Won't that break texture views? I.e. a view of rgb10 via rgb10a2 or vice
> versa.

GL_RGB10 is not supported by texture views.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek