[Mesa-dev] [PATCH 3/9] squash: Increase nir_variable_data::mode to 5 bits

Jason Ekstrand jason at jlekstrand.net
Tue Mar 15 20:22:37 UTC 2016


Thanks for catching this!  It came up before when I reworked function calls
but, thanks to the order in which things got merged, it had to be done in
your series.

On Mon, Mar 14, 2016 at 11:56 PM, Jordan Justen <jordan.l.justen at intel.com>
wrote:

> Prevents:
>
> ../../../../../src/compiler/nir/nir.h:176:30: warning:
> 'nir_variable::nir_variable_data::mode' is too small to hold all values of
> 'enum nir_variable_mode'
>        nir_variable_mode mode:4;
>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/compiler/nir/nir.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index bbf0ff3..7d2bd03 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -173,7 +173,7 @@ typedef struct nir_variable {
>         *
>         * \sa nir_variable_mode
>         */
> -      nir_variable_mode mode:4;
> +      nir_variable_mode mode:5;
>
>        /**
>         * Interpolation mode for shader inputs / outputs
> --
> 2.7.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160315/a30625c7/attachment.html>


More information about the mesa-dev mailing list