[Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

[Samuel Iglesias Gonsálvez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 15/03/16 08:41, Iago Toral wrote:
> On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote:
[...]
>> +   nir_alu_type type; + union { -      uint32_t u; -
>> int32_t i; -      float f; +      uint64_t u; +      int64_t i; +
>> double d; } data; } nir_search_constant;
> 
> Maybe we should rename these to u64, i64 as f64 like you suggested
> for a similar case in another patch?
> 

We decided to do the following changes to this patch series (among the
others already agreed): rename these fields and add the inline helper
functions to get type size and base type from nir_alu_type enum
values. So the rest of the fp64 patches will have those changes
already and everything would be easier to maintain.

One question for Jason: Should we squash all the patches of this
series in a single commit as originally proposed? I'd rather have them
separately so we understand what each patch does in case of a git
bisect, however I don't have a strong opinion against squashing.

Thanks,

Sam
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJW6R3eAAoJEH/0ujLxfcNDE+IQAL9qvKvhRb7OMZi3ypNDQo9q
mtINFSGu/rwkVFl9w9pUcjKg4mDh19odBq8g5bqaaYBBVS84TGX1svAx1CnISytJ
kBE16tGUcV5O3qJEFQ4VMNbhhSz3TuRf+TfU9g5H9J0yhMEuZLXzmLHcIWItiObL
A5A9n4S8F0VDgT9nOyL8LR7Ur5yWR+ZuR6xHiDC9bcijF2TuUvSbkB3EO2hVUl8n
ULtsJf239D2712LG+dKlxcdnv8WAIA3JaVR62v3QbDj3LKi+u9zKhnObcEwb1/Kh
jiWvLolf81ZYOoeFJ1v6OK5rRgKXVQWvf1tJ0Cb0W01JhG7IdK5Bto5lEiPnWhnj
BQM60zb0QrWTPIczOEXyqTphKl1McixxqVVLY+Oep79dC0MntFXtAPEF2UEu5mmR
KcZAq8n3gZ8P0YogFtGU8+PlkbEq+b5sMQrRsx/QTf2+DMUm2DTQupggE/yGrBdn
mWx2qA1gqD/lRCQwpOF0PvF/rWf7nwE4TWOLAS9Z7dnNzGVj3HWnLcBIsDE3WVx8
mdZUoaH9iWuEC2LwVOwDGYi046JSxarTCPN3c6EWjHRIOrtPNk1J4XoLyOi2Jc1n
xPFCQ/X8T47RturKT4YkArGMy5WTTV99C2mttF/jAl48WcY3pMwaMmzDVa2fC3r8
xGuwFGt0beY+XhS8mo6G
=mZ3I
-----END PGP SIGNATURE-----