[Mesa-dev] [PATCH 05/10] radeonsi: ignore PIPE_BIND_LINEAR in si_is_format_supported

[Christian König]

Am 09.03.2016 um 15:53 schrieb Marek Olšák:
> On Wed, Mar 9, 2016 at 4:54 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 08.03.2016 21:21, Christian König wrote:
>>> From: Christian König <christian.koenig at amd.com>
>>>
>>> Linear layout should work for all formats as well.
>> The hardware actually doesn't support linear e.g. for compressed formats
>> or depth/stencil formats.
> The driver ignores the flag for compressed formats. It doesn't ignore
> the flag for depth/stencil formats, but it does support binding a
> linear depth/stencil buffer as a color buffer.
>
> That said, I think PIPE_BIND_LINEAR should not be an allowed parameter
> of is_format_supported (unless we have a very good reason to allow it).

Why not? In my use case the state tracker just translates the format it 
got from the application into the internal representation and queries 
the driver if the result would be supported or not.

I could query without the linear flag as well, but I think that this 
wouldn't be the correct approach.

How about the attached updated patch? I'm allowing PIPE_BIND_LINEAR now 
when it's not depth/stencil or compressed.

Regards,
Christian.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-radeonsi-ignore-PIPE_BIND_LINEAR-in-si_is_format_sup.patch
Type: text/x-diff
Size: 1179 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160317/7a70093a/attachment.patch>