[Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

[Nicolai Hähnle]

On 17.03.2016 11:50, Ilia Mirkin wrote:
> On Thu, Mar 17, 2016 at 12:47 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> On 16.03.2016 19:43, Brian Paul wrote:
>>>
>>> The return type is float, which is what was implicitly used before,
>>> AFAICT.
>>
>>
>> Isn't this technically incorrect when the uploaded texture is integer?
>>
>> To be honest, it's not really clear to me what the return type is supposed
>> to mean. I don't think any of the hardware drivers uses it.
>
> Adreno has different texture instructions depending on the desired
> return type. If you use a float return type on an int texture, you
> will get a floating point value of that integer (i.e. if the actual
> textured value were 100, you'd get 100.0f returned if you did
> sam.f32).

I guess this mean PBO uploads of integer textures is currently broken 
for Adreno?

Cheers,
Nicolai

>
>    -ilia
>