[Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

Ilia Mirkin imirkin at alum.mit.edu
Sat Mar 19 15:25:58 UTC 2016


On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen
<bas at basnieuwenhuizen.nl> wrote:
> That would limit us to supporting sample counts for which we have
> texture formats.
>
> As far as I understand with radeonsi we can support 16 samples without
> any attachments, but all formats are limited to <= 8 samples.

So you're going to end up with a situation where GL_MAX_SAMPLES is
less than GL_MAX_FRAMEBUFFER_SAMPLES? I don't know that that's a
useful thing to have. This implementation still has the problem of
only supporting POT MSAA levels (although tbh I'm not 100% sure
there's hw out there that supports NPOT MSAA levels). If people really
want this, I think the way to go would be to make
is_format_supported() work with PIPE_FORMAT_NONE and do it that way.

Also, are you *sure* that's the case on radeonsi? I find it very odd
that the rasterizer would support a higher MSAA level than the highest
attachment would...

  -ilia


More information about the mesa-dev mailing list