[Mesa-dev] [PATCH v2] nvc0/ir: Use double constant in `handleSQRT()`

Ilia Mirkin imirkin at alum.mit.edu
Sat Mar 19 16:56:47 UTC 2016


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Thanks for noticing this!

On Sat, Mar 19, 2016 at 12:56 PM, Pierre Moreau <pierre.morrow at free.fr> wrote:
> v2: Use "Fixes: sha1 (subject)" format for the fixes section, as pointed out
>     by Ilia Mirin
>
> Fixes: a100d89d0998 ("nv50,nvc0: Fix invalid constant.")
> Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
> index 01364b3..b88e351 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
> @@ -1780,7 +1780,7 @@ NVC0LoweringPass::handleSQRT(Instruction *i)
>  {
>     if (i->dType == TYPE_F64) {
>        Value *pred = bld.getSSA(1, FILE_PREDICATE);
> -      Value *zero = bld.loadImm(NULL, 0);
> +      Value *zero = bld.loadImm(NULL, 0.0);
>        Value *dst = bld.getSSA(8);
>        bld.mkOp1(OP_RSQ, i->dType, dst, i->getSrc(0));
>        bld.mkCmp(OP_SET, CC_LE, i->dType, pred, i->dType, i->getSrc(0), zero);
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list