[Mesa-dev] [PATCH] tgsi: drop unused set_exec/kill_mask interfaces.

[Brian Paul]

On 03/21/2016 06:29 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> These don't get used and haven't been in git history from what I can
> see, so drop them.

Well, tgsi_set_exec_mask() was used, but had no effect.


>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   src/gallium/auxiliary/draw/draw_gs.c      |  6 ------
>   src/gallium/auxiliary/draw/draw_vs_exec.c |  6 ------
>   src/gallium/auxiliary/tgsi/tgsi_exec.h    | 25 -------------------------
>   3 files changed, 37 deletions(-)
>
> diff --git a/src/gallium/auxiliary/draw/draw_gs.c b/src/gallium/auxiliary/draw/draw_gs.c
> index 6b33341..fcef31b 100644
> --- a/src/gallium/auxiliary/draw/draw_gs.c
> +++ b/src/gallium/auxiliary/draw/draw_gs.c
> @@ -206,12 +206,6 @@ static unsigned tgsi_gs_run(struct draw_geometry_shader *shader,
>   {
>      struct tgsi_exec_machine *machine = shader->machine;
>
> -   tgsi_set_exec_mask(machine,
> -                      1,
> -                      input_primitives > 1,
> -                      input_primitives > 2,
> -                      input_primitives > 3);
> -
>      /* run interpreter */
>      tgsi_exec_machine_run(machine);
>
> diff --git a/src/gallium/auxiliary/draw/draw_vs_exec.c b/src/gallium/auxiliary/draw/draw_vs_exec.c
> index abd64f5..3fd8ef3 100644
> --- a/src/gallium/auxiliary/draw/draw_vs_exec.c
> +++ b/src/gallium/auxiliary/draw/draw_vs_exec.c
> @@ -159,12 +159,6 @@ vs_exec_run_linear( struct draw_vertex_shader *shader,
>            input = (const float (*)[4])((const char *)input + input_stride);
>         }
>
> -      tgsi_set_exec_mask(machine,
> -                         1,
> -                         max_vertices > 1,
> -                         max_vertices > 2,
> -                         max_vertices > 3);
> -
>         /* run interpreter */
>         tgsi_exec_machine_run( machine );
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.h b/src/gallium/auxiliary/tgsi/tgsi_exec.h
> index 12a6875..991c3bf 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_exec.h
> +++ b/src/gallium/auxiliary/tgsi/tgsi_exec.h
> @@ -196,10 +196,6 @@ struct tgsi_sampler
>   #define TGSI_EXEC_TEMP_HALF_I       (TGSI_EXEC_NUM_TEMPS + 3)
>   #define TGSI_EXEC_TEMP_HALF_C       0
>
> -/* execution mask, each value is either 0 or ~0 */
> -#define TGSI_EXEC_MASK_I            (TGSI_EXEC_NUM_TEMPS + 3)
> -#define TGSI_EXEC_MASK_C            1
> -
>   /* 4 register buffer for various purposes */
>   #define TGSI_EXEC_TEMP_R0           (TGSI_EXEC_NUM_TEMPS + 4)
>   #define TGSI_EXEC_NUM_TEMP_R        4
> @@ -397,27 +393,6 @@ boolean
>   tgsi_check_soa_dependencies(const struct tgsi_full_instruction *inst);
>
>
> -static inline void
> -tgsi_set_kill_mask(struct tgsi_exec_machine *mach, unsigned mask)
> -{
> -   mach->Temps[TGSI_EXEC_TEMP_KILMASK_I].xyzw[TGSI_EXEC_TEMP_KILMASK_C].u[0] =
> -      mask;
> -}
> -
> -
> -/** Set execution mask values prior to executing the shader */
> -static inline void
> -tgsi_set_exec_mask(struct tgsi_exec_machine *mach,
> -                   boolean ch0, boolean ch1, boolean ch2, boolean ch3)
> -{
> -   int *mask = mach->Temps[TGSI_EXEC_MASK_I].xyzw[TGSI_EXEC_MASK_C].i;
> -   mask[0] = ch0 ? ~0 : 0;
> -   mask[1] = ch1 ? ~0 : 0;
> -   mask[2] = ch2 ? ~0 : 0;
> -   mask[3] = ch3 ? ~0 : 0;
> -}
> -
> -
>   extern void
>   tgsi_exec_set_constant_buffers(struct tgsi_exec_machine *mach,
>                                  unsigned num_bufs,
>

Reviewed-by: Brian Paul <brianp at vmware.com>