[Mesa-dev] [V2 00/19] Add infrastructure for GL_OES_texture_compression_astc

[Brian Paul]

On 03/21/2016 03:03 PM, Anuj Phogat wrote:
> I don't have a hardware which supports this extension and I realized it
> after writing these patches. This blocks the testing of these patches.
> So, I'm sure there will be few things left out in this series. But I
> think it'll be nice to have 90% of the infrastructure ready when we
> will have a hardware to enable the extension.
>
> V2, NEW patches are based on the feedback by Brian Paul.

The v2 changes look good to me.

For the series, Reviewed-by: Brian Paul <brianp at vmware.com>



>
> Anuj Phogat (19):
>
> V1  mesa: Add block depth field in struct gl_format_info
> NEW mesa: Add a helper function to query 3D block sizes
> NEW mesa: Add an assert for BlockDepth in _mesa_get_format_block_size()
> NEW mesa: Handle 3d block sizes in getteximage error checks
> V2  mesa: Handle 3d block sizes in teximage error checks
> NEW mesa: Handle 3d block sizes in _mesa_compute_compressed_pixelstore
> V2  mesa: Account for block depth in _mesa_format_image_size()
> V1  glapi: Update dispatch XML files for OES_texture_compression_astc.xml
> V1  mesa: Add mesa formats for astc 3d formats
> V1  mesa: Add entries for astc 3d formats initializing struct
>      gl_format_info
> V1  mesa: Add OES_texture_compression_astc to extension table and
>      gl_extensions
> V1  mesa: Align the values of #define's in glheader.h
> V1  mesa: Add the missing defines for GL_OES_texture_compression_astc
> V1  mesa: Add a helper function is_astc_3d_format()
> V1  mesa: Account for astc 3d formats in _mesa_is_astc_format()
> V1  mesa: Handle astc 3d formats in _mesa_base_tex_format()
> V1  mesa: Handle astc 3d formats in _mesa_get_compressed_formats()
> V1  mesa: Enable translation between astc 3d gl formats and mesa formats
> V1  swrast: Add texfetch_funcs entries for astc 3d formats
>
>   src/mapi/glapi/gen/Makefile.am                     |   1 +
>   .../glapi/gen/OES_texture_compression_astc.xml     |  61 +++
>   src/mapi/glapi/gen/gl_API.xml                      |   2 +
>   src/mesa/main/extensions_table.h                   |   1 +
>   src/mesa/main/format_info.py                       |   5 +-
>   src/mesa/main/format_parser.py                     |  15 +-
>   src/mesa/main/formats.c                            |  72 ++-
>   src/mesa/main/formats.csv                          | 550 +++++++++++----------
>   src/mesa/main/formats.h                            |  25 +
>   src/mesa/main/glformats.c                          |  54 +-
>   src/mesa/main/glheader.h                           |  81 +--
>   src/mesa/main/mtypes.h                             |   1 +
>   src/mesa/main/texcompress.c                        | 109 ++++
>   src/mesa/main/texgetimage.c                        |  21 +-
>   src/mesa/main/teximage.c                           |  19 +-
>   src/mesa/main/texstore.c                           |   6 +-
>   src/mesa/swrast/s_texfetch.c                       |  23 +-
>   17 files changed, 703 insertions(+), 343 deletions(-)
>   create mode 100644 src/mapi/glapi/gen/OES_texture_compression_astc.xml
>