[Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

Jordan Justen jordan.l.justen at intel.com
Tue Mar 22 20:51:42 UTC 2016


What does 532172 in the subject refer to?

On 2016-03-22 12:45:48, Tim Rowley wrote:
> Highlights include:
>   * code style fixes
>   * start removing win32 types
>   * switch DC/DS rings to ringbuffer datastructure
>   * rdtsc bucket support for shaders
>   * address some coverity issues
>   * user clip planes
>   * global arena
>   * support llvm-svn

From this commit message, it seems clear that this single patch is
doing a whole lot. Usually that's a good sign that it should be split
into multiple patches.

However, since this is only changing your driver, you can probably
take any sort of patches that you like. :)

There is arguably little value to sending out a patch like this, since
it is very difficult to review. In other words, perhaps if you are
going to make big, unreviewable patches like this that only change
your driver, then you might as well just push them straight away.

(But, it would be better, in my opinion, to try to split up the
changes and let them be reviewed.)

-Jordan


More information about the mesa-dev mailing list