[Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

[Stéphane Marchesin]

On Tue, Mar 22, 2016 at 8:55 PM, Rowley, Timothy O
<timothy.o.rowley at intel.com> wrote:
>
>> On Mar 22, 2016, at 3:51 PM, Justen, Jordan L <jordan.l.justen at intel.com> wrote:
>>
>> What does 532172 in the subject refer to?
>
> swr rasterizer development happens in another source control system.  532172 is a revision id to checkpoint where we’ve pushed the changes publicly.
>
>> From this commit message, it seems clear that this single patch is
>> doing a whole lot. Usually that's a good sign that it should be split
>> into multiple patches.
>>
>> However, since this is only changing your driver, you can probably
>> take any sort of patches that you like. :)
>>
>> There is arguably little value to sending out a patch like this, since
>> it is very difficult to review. In other words, perhaps if you are
>> going to make big, unreviewable patches like this that only change
>> your driver, then you might as well just push them straight away.
>>
>> (But, it would be better, in my opinion, to try to split up the
>> changes and let them be reviewed.)
>
> Yes, there’s a lot in this patch.  I froze the public version of the rasterizer when I began the upstreaming process mid February, so this is syncing up with about a month’s worth of development.
>
> I also have this change as a series of 81 commits.  Not sure if that would be preferable by the community or if people would be interested in reviewing the series, as issues with early commits might already be addressed later in the patch set.

>From a consumer perspective, I am less interested in swr if I can't
bisect it to find and fix issues locally. Landing such large patches
would definitely prevent bisectability. Even if you have another
upstream repo (after all, that's what git is about), what prevents you
from turning all these commits into mesa commits, possibly with a
script if that's too tedious?

Stéphane


>
> -Tim
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev