[Mesa-dev] [PATCH 04/14] mesa: Add comment to framebuffer_parameteri()

[Marek Olšák]

On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
<eocallaghan at alterapraxis.com> wrote:
> Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
> ---
>  src/mesa/main/fbobject.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index bb8d4c3..42f40b2 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -1369,6 +1369,11 @@ _mesa_BindRenderbufferEXT(GLenum target, GLuint renderbuffer)
>     bind_renderbuffer(target, renderbuffer, true);
>  }
>
> +/**
> + * ARB_framebuffer_no_attachment - Application passes requested param's
> + * here. N.B., NumSamples requested need not be _NumSamples which is
> + * what the hw supports.
> + */

I wouldn't say that _NumSamples is what the hardware supports.
_NumSamples is really just a derived state calculated by a driver,
which is what the underscore means.

Also, I guess most non-native and even some native speakers don't know
what N.B. means.

Marek