[Mesa-dev] [RFC 4/4] gallium: Distinguish between shader IR's in get_compute_param.

[Ilia Mirkin]

On Thu, Mar 24, 2016 at 9:43 PM, Bas Nieuwenhuizen
<bas at basnieuwenhuizen.nl> wrote:
> diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h
> index 4f30e75..6d44cf7 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -109,13 +109,16 @@ struct pipe_screen {
>
>     /**
>      * Query a compute-specific capability/parameter/limit.
> -    * \param param  one of PIPE_COMPUTE_CAP_x
> -    * \param ret    pointer to a preallocated buffer that will be
> -    *               initialized to the parameter value, or NULL.
> -    * \return       size in bytes of the parameter value that would be
> -    *               returned.
> +    * \param ir_type shader IR type for which the param applies, or don't care
> +    *                if the param is not shader related
> +    * \param param   one of PIPE_COMPUTE_CAP_x
> +    * \param ret     pointer to a preallocated buffer that will be
> +    *                initialized to the parameter value, or NULL.
> +    * \return        size in bytes of the parameter value that would be
> +    *                returned.
>      */
>     int (*get_compute_param)(struct pipe_screen *,
> +                           unsigned ir_type,

Should this be a enum pipe_shader_ir instead?

>                             enum pipe_compute_cap param,
>                             void *ret);