[Mesa-dev] [PATCH 2/2] gallium/util: fix up inaccurate behavior of util_framebuffer_state_equal

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I would personally move the for loop down below the "simple" checks.
Purely optional.

On Sun, Mar 27, 2016 at 2:25 PM, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>  src/gallium/auxiliary/util/u_framebuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_framebuffer.c b/src/gallium/auxiliary/util/u_framebuffer.c
> index 2e0ef74..3798d9b 100644
> --- a/src/gallium/auxiliary/util/u_framebuffer.c
> +++ b/src/gallium/auxiliary/util/u_framebuffer.c
> @@ -55,7 +55,7 @@ util_framebuffer_state_equal(const struct pipe_framebuffer_state *dst,
>         dst->height != src->height)
>        return FALSE;
>
> -   for (i = 0; i < Elements(src->cbufs); i++) {
> +   for (i = 0; i < src->nr_cbufs; i++) {
>        if (dst->cbufs[i] != src->cbufs[i]) {
>           return FALSE;
>        }
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev