[Mesa-dev] [PATCH 11/11] glapi/glx: Mark the indirect swapped dispatch functions _X_COLD

Ian Romanick idr at freedesktop.org
Mon Mar 28 18:00:02 UTC 2016


Interesting... I had to look up what __attribute__('cold') did.  Learn
something new every day...

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 03/24/2016 11:10 AM, Adam Jackson wrote:
> A modest size savings:
> 
>    text	   data	    bss	    dec	    hex	filename
>  264143	  15608	    232	 279983	  445af libglx.so.before
>  254303	  15608	    232	 270143	  41f3f libglx.so.after
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  src/mapi/glapi/gen/glX_proto_recv.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py
> index 7eb19df..9ef5206 100644
> --- a/src/mapi/glapi/gen/glX_proto_recv.py
> +++ b/src/mapi/glapi/gen/glX_proto_recv.py
> @@ -55,15 +55,15 @@ class PrintGlxDispatch_h(gl_XML.gl_print_base):
>              if not func.ignore and not func.vectorequiv:
>                  if func.glx_rop:
>                      print 'extern _X_HIDDEN void __glXDisp_%s(GLbyte * pc);' % (func.name)
> -                    print 'extern _X_HIDDEN void __glXDispSwap_%s(GLbyte * pc);' % (func.name)
> +                    print 'extern _X_HIDDEN _X_COLD void __glXDispSwap_%s(GLbyte * pc);' % (func.name)
>                  elif func.glx_sop or func.glx_vendorpriv:
>                      print 'extern _X_HIDDEN int __glXDisp_%s(struct __GLXclientStateRec *, GLbyte *);' % (func.name)
> -                    print 'extern _X_HIDDEN int __glXDispSwap_%s(struct __GLXclientStateRec *, GLbyte *);' % (func.name)
> +                    print 'extern _X_HIDDEN _X_COLD int __glXDispSwap_%s(struct __GLXclientStateRec *, GLbyte *);' % (func.name)
>  
>                      if func.glx_sop and func.glx_vendorpriv:
>                          n = func.glx_vendorpriv_names[0]
>                          print 'extern _X_HIDDEN int __glXDisp_%s(struct __GLXclientStateRec *, GLbyte *);' % (n)
> -                        print 'extern _X_HIDDEN int __glXDispSwap_%s(struct __GLXclientStateRec *, GLbyte *);' % (n)
> +                        print 'extern _X_HIDDEN _X_COLD int __glXDispSwap_%s(struct __GLXclientStateRec *, GLbyte *);' % (n)
>  
>          return
>  
> 



More information about the mesa-dev mailing list