[Mesa-dev] [PATCH 1/2] glsl: add missing types for buffer images

[Samuel Pitoiset]

On 03/29/2016 09:32 PM, Ilia Mirkin wrote:
> On Tue, Mar 29, 2016 at 3:30 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>>
>>
>> On 03/29/2016 09:23 PM, Ilia Mirkin wrote:
>>>
>>> I still see
>>>
>>> 0:7(1): error: No precision specified in this scope for type
>>> `imageBuffer'
>>>
>>> for
>>>
>>> #version 310 es
>>> #extension GL_EXT_texture_buffer : require
>>>
>>> precision highp imageBuffer;
>>>
>>> layout (local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
>>> layout (rgba32f, binding=0) writeonly uniform imageBuffer u_image;
>>>
>>> after applying your series. Is this not what you were trying to fix?
>>
>>
>> On which card do you try? because I have the following output:
>
> i965 SKL
>
>>
>> MESA_GLES_VERSION_OVERRIDE=3.1 ./deqp-gles31
>> --deqp-case=dEQP-GLES31.functional.image_load_store.buffer.load_store.rgba32f
>> dEQP Core git-cf4407563b4783b69214f3542728806468b200a6 (0xcf440756)
>> starting..
>>    target implementation = 'X11 EGL/GLX'
>>
>> Test case
>> 'dEQP-GLES31.functional.image_load_store.buffer.load_store.rgba32f'..
>> Compute shader compile time = 3.087000 ms
>> Test case duration in microseconds = 5985 us
>>    Fail (Program compilation failed)
>>
>> The assert has gone but something else is still wrong.
>
> Yeah... there must be another spot that needs to be fixed up. I just
> sent out a patch for yet-another issue relating to all this. Can you
> try to track this one down?

Yeah, I just saw the patch, I was looking at the code but you are 
definitely too fast. :-)

>