[Mesa-dev] [PATCH] xlib: add support for GLX_ARB_create_context

[Brian Paul]

On 03/29/2016 02:27 PM, Emil Velikov wrote:
> On 26 March 2016 at 17:45, Brian Paul <brianp at vmware.com> wrote:
>> This adds the glXCreateContextAttribsARB() function for the xlib/swrast
>> driver.  This allows more piglit tests to run with this driver.
>>
>> For example, without this patch we get:
>> $ bin/fbo-generatemipmap-1d -auto
>> piglit: error: waffle_config_choose failed due to WAFFLE_ERROR_UNSUPPORTED_
>> ON_PLATFORM: GLX_ARB_create_context is required in order to request an OpenGL
>> version not equal to the default value 1.0
>> piglit: error: Failed to create waffle_config for OpenGL 2.0 Compatibility Context
>> piglit: info: Failed to create any GL context
>> PIGLIT: {"result": "skip" }
>
> Fwiw I believe that the 'issue' is within piglit. Namely, waffle
> follows glx/wgl semantics which dictate that if you want to specify
> the version of the context during creation you need the
> *ARB_create_context extension. Perhaps piglit should fall-back to
> creating the context without mentioning the version, and checking it
> afterwords ?
>
> I'll see if I can cook up a fix for that, as this approach feels a bit hackish.

Sounds good.  I think piglit/waffle could just glXCreateContext() if the 
version is <= 30.

-Brian