[Mesa-dev] [PATCH 1/3] ptn: Silence unused parameter warning

Iago Toral itoral at igalia.com
Thu Mar 31 06:41:59 UTC 2016


Series is:
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Wed, 2016-03-30 at 16:23 -0700, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> The KIL instruction doesn't have a destination, so ptn_kil never uses
> dest.
> 
> program/prog_to_nir.c: In function ‘ptn_kil’:
> program/prog_to_nir.c:547:38: warning: unused parameter ‘dest’ [-Wunused-parameter]
>  ptn_kil(nir_builder *b, nir_alu_dest dest, nir_ssa_def **src)
>                                       ^
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/program/prog_to_nir.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
> index 16b79c9..ce25f6d 100644
> --- a/src/mesa/program/prog_to_nir.c
> +++ b/src/mesa/program/prog_to_nir.c
> @@ -545,7 +545,7 @@ ptn_lrp(nir_builder *b, nir_alu_dest dest, nir_ssa_def **src)
>  }
>  
>  static void
> -ptn_kil(nir_builder *b, nir_alu_dest dest, nir_ssa_def **src)
> +ptn_kil(nir_builder *b, nir_ssa_def **src)
>  {
>     nir_ssa_def *cmp = b->shader->options->native_integers ?
>        nir_bany_inequal4(b, nir_flt(b, src[0], nir_imm_float(b, 0.0)), nir_imm_int(b, 0)) :
> @@ -830,7 +830,7 @@ ptn_emit_instruction(struct ptn_compile *c, struct prog_instruction *prog_inst)
>        break;
>  
>     case OPCODE_KIL:
> -      ptn_kil(b, dest, src);
> +      ptn_kil(b, src);
>        break;
>  
>     case OPCODE_CMP:




More information about the mesa-dev mailing list