[Mesa-dev] [PATCH 3/3] egl: android: remove explicit glFlush call

Emil Velikov emil.l.velikov at gmail.com
Sun May 1 11:42:55 UTC 2016


The DRI flush extension should already do the same thing.

Cc: Rob Herring <robh at kernel.org>
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
NOTE: Untested, although based on my humble understanding of things it
should be fine.

Worst case scenario we can use flush_with_flags(__DRI2_FLUSH_CONTEXT),
as opposed to the direct dive into the GL dispatch.
---
 src/egl/drivers/dri2/platform_android.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
index fc9cd68..25d02f5 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b/src/egl/drivers/dri2/platform_android.c
@@ -432,12 +432,6 @@ droid_swap_buffers(_EGLDriver *drv, _EGLDisplay *disp, _EGLSurface *draw)
    if (dri2_surf->base.Type != EGL_WINDOW_BIT)
       return EGL_TRUE;
 
-   if (dri2_drv->glFlush) {
-      ctx = _eglGetCurrentContext();
-      if (ctx && ctx->DrawSurface == &dri2_surf->base)
-         dri2_drv->glFlush();
-   }
-
    dri2_flush_drawable_for_swapbuffers(disp, draw);
 
    if (dri2_surf->buffer)
-- 
2.8.0



More information about the mesa-dev mailing list