[Mesa-dev] [PATCH] st/mesa: fix blit-based GetTexImage for non-finalized textures

Ilia Mirkin imirkin at alum.mit.edu
Sun May 1 15:12:30 UTC 2016

On Sun, May 1, 2016 at 11:05 AM, Marek Olšák <maraeo at gmail.com> wrote:
> On Sun, May 1, 2016 at 5:00 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Nice find! An alternative way of fixing it is below. Thoughts?
> I don't care much, but I think that your way adds more complexity and
> is more prone to similar bugs in the future.

Yeah, I was actually thinking the same thing... my way works for the
simpler cases, but if e.g. someone creates a full texture that gets
properly merged, and then later modifies it, we may run into trouble.
Thinking about non-finalized textures is non-fun, so your original
patch is

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

More information about the mesa-dev mailing list