[Mesa-dev] [PATCH 7/8] i965: Make opcode_descs and gen_from_devinfo() static.

Matt Turner mattst88 at gmail.com
Sun May 1 18:42:25 UTC 2016


The previous commit replaced direct uses of opcode_descs with calls to
the wrapper function, which should be the only method of accessing
opcode_descs's data. As a result gen_from_devinfo() can also be made
static.
---
 src/mesa/drivers/dri/i965/brw_eu.c | 4 ++--
 src/mesa/drivers/dri/i965/brw_eu.h | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c
index 5490738..9dce5cc 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.c
+++ b/src/mesa/drivers/dri/i965/brw_eu.c
@@ -355,7 +355,7 @@ enum gen {
 #define GEN_GE(gen) (~((gen) - 1) | gen)
 #define GEN_LE(gen) (((gen) - 1) | gen)
 
-const struct opcode_desc opcode_descs[128] = {
+static const struct opcode_desc opcode_descs[128] = {
    [BRW_OPCODE_ILLEGAL] = {
       .name = "illegal", .nsrc = 0, .ndst = 0, .gens = GEN_ALL,
    },
@@ -566,7 +566,7 @@ const struct opcode_desc opcode_descs[128] = {
    },
 };
 
-int
+static enum gen
 gen_from_devinfo(const struct brw_device_info *devinfo)
 {
    switch (devinfo->gen) {
diff --git a/src/mesa/drivers/dri/i965/brw_eu.h b/src/mesa/drivers/dri/i965/brw_eu.h
index a212f51..30bd903 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.h
+++ b/src/mesa/drivers/dri/i965/brw_eu.h
@@ -552,10 +552,6 @@ struct opcode_desc {
    int      gens;
 };
 
-extern const struct opcode_desc opcode_descs[128];
-
-int gen_from_devinfo(const struct brw_device_info *devinfo);
-
 const struct opcode_desc *
 brw_opcode_desc(const struct brw_device_info *devinfo, enum opcode opcode);
 
-- 
2.7.3



More information about the mesa-dev mailing list