[Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

[Jonathan Gray]

On Mon, May 02, 2016 at 02:23:46AM -0700, Jason Ekstrand wrote:
> On May 1, 2016 11:24 PM, "Jonathan Gray" <jsg at jsg.id.au> wrote:
> >
> > % pattern rules are a GNU extension.  Convert the use of one to a
> > suffix rule to allow this to build on OpenBSD.
> >
> > Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
> > ---
> >  src/intel/genxml/Makefile.am | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/intel/genxml/Makefile.am b/src/intel/genxml/Makefile.am
> > index f493d48..ea68fb9 100644
> > --- a/src/intel/genxml/Makefile.am
> > +++ b/src/intel/genxml/Makefile.am
> > @@ -28,7 +28,9 @@ BUILT_SOURCES =
>  \
> >
> >  PYTHON3_GEN = $(AM_V_GEN)$(PYTHON3) $(PYTHON_FLAGS)
> >
> > -%_pack.h : %.xml gen_pack_header.py
> > +SUFFIXES = _pack.h .xml
> > +
> > +.xml_pack.h : gen_pack_header.py
> >         $(PYTHON3_GEN) $(srcdir)/gen_pack_header.py $< > $@
> 
> We'd better also fix up all the places we include these files. :-)

The generated filenames don't change, there is no need to:

Making all in genxml
python3.4  ./gen_pack_header.py gen6.xml > gen6_pack.h
python3.4  ./gen_pack_header.py gen7.xml > gen7_pack.h
python3.4  ./gen_pack_header.py gen75.xml > gen75_pack.h
python3.4  ./gen_pack_header.py gen8.xml > gen8_pack.h
python3.4  ./gen_pack_header.py gen9.xml > gen9_pack.h