[Mesa-dev] [PATCH 11/59] i965/eu: allow doubles in math instructions

Samuel Iglesias Gonsálvez siglesias at igalia.com
Tue May 3 06:16:21 UTC 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 29/04/16 18:44, Connor Abbott wrote:
> IIRC this is wrong. I think I added it in the beginning before I 
> tested to see if the spec was lying about math instructions not
> being supported on doubles (it wasn't) and we can delete it now
> that we lower away all the possible math operations on doubles.
> 

OK, I will remove it.

Thanks Connor!

Sam

> On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez 
> <siglesias at igalia.com> wrote:
>> From: Connor Abbott <connor.w.abbott at intel.com>
>> 
>> --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 6 ++++-- 1 file
>> changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c
>> b/src/mesa/drivers/dri/i965/brw_eu_emit.c index e5057a0..4c08883
>> 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++
>> b/src/mesa/drivers/dri/i965/brw_eu_emit.c @@ -1995,8 +1995,10 @@
>> void gen6_math(struct brw_codegen *p, assert(src1.file ==
>> BRW_GENERAL_REGISTER_FILE || (devinfo->gen >= 8 && src1.file ==
>> BRW_IMMEDIATE_VALUE)); } else { -      assert(src0.type ==
>> BRW_REGISTER_TYPE_F); -      assert(src1.type ==
>> BRW_REGISTER_TYPE_F); +      assert(src0.type ==
>> BRW_REGISTER_TYPE_F || +             src0.type ==
>> BRW_REGISTER_TYPE_DF); +      assert(src1.type ==
>> BRW_REGISTER_TYPE_F || +             src1.type ==
>> BRW_REGISTER_TYPE_DF); if (function == BRW_MATH_FUNCTION_POW) { 
>> assert(src1.file == BRW_GENERAL_REGISTER_FILE || (devinfo->gen >=
>> 8 && src1.file == BRW_IMMEDIATE_VALUE)); -- 2.5.0
>> 
>> _______________________________________________ mesa-dev mailing
>> list mesa-dev at lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKEI1AAoJEH/0ujLxfcND03IP/3roPqh4rwLY48EfPk4VRaMV
ejf1tP6mXsF+sp+wBDEzQDKPjKb7lfWlHVYZFkXq0nGoxY21rBBbEE9lEelGjTYN
a6SaK9QEDlFGoUcNWjjU9UXU8xY8Lx7fca2MYbwUTd0KuDtn9rbwrRhyx2i2qWa+
k4vQqcqNZwaCnEqeXQg3fsDiWPJ0V74mtQ5zPme0vJXJLQtsb2zzk3HvL4jNvk1f
Y1KsqjgL9yvIgC1jE+waVkesfEOe1OPEMw+Uo3sPjRwidS9GxhoIYePpfpjZz9BR
cDWyPHvkSazKGBRHV1tWitTJHJhiyBCBEn3WOkk+CByGALFSyrsQ4wFnbZMXKJ4s
orZ7+KR+eUG/6VydjEg3rZZXk+AEjlK+T8WNN60n3B126iArv20vAi9oQN1Nx9Yi
0MG1e5qxdVDa/94wewuuQHbPjUNFXG9vziCnWJmQpIrjTJeG3iS1TamwbfXY2n6z
/IYL+69e4k+oe31OnxDq1gHikFTGoQlRAX9RCPCN2AmG+GuJrptul5SZDbog7e+8
CcGPhSNT7um7qK948/qeKo2iMcxXGOmFye8fZzv0mMDg29UblArTaDdvu2OZFyAs
j3Kk76FstIjq3ML1v5mNLvxYFYYX5nYg6Ersvj2Xn3w0e0Ccj3sSM5SIUUvHJQ5L
3qD8OwRfreN17DcmX4ys
=ia69
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list