[Mesa-dev] [PATCH 30/59] i965/fs/nir: translate double pack/unpack

Samuel Iglesias Gonsálvez siglesias at igalia.com
Tue May 3 07:28:18 UTC 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 02/05/16 10:17, Pohjolainen, Topi wrote:
> On Fri, Apr 29, 2016 at 01:29:27PM +0200, Samuel Iglesias Gons?lvez
> wrote:
>> From: Connor Abbott <connor.w.abbott at intel.com>
>> 
>> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 12 ++++++++++++ 1
>> file changed, 12 insertions(+)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
>> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 3ed3343..ca1f24f
>> 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++
>> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp @@ -1090,6 +1090,18 @@
>> fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr
>> *instr) inst->saturate = instr->dest.saturate; break;
>> 
>> +   case nir_op_pack_double_2x32_split: +
>> bld.emit(FS_OPCODE_PACK, result, op[0], op[1]); +      break; + +
>> case nir_op_unpack_double_2x32_split_x: +      bld.MOV(result,
>> stride(retype(op[0], BRW_REGISTER_TYPE_UD), 2)); +      break; + 
>> +   case nir_op_unpack_double_2x32_split_y: +
>> bld.MOV(result, stride(horiz_offset(retype(op[0],
>> BRW_REGISTER_TYPE_UD), 1), 2));
> 
> Perhaps fix the overflowing line:
> 
> bld.MOV( result, stride(horiz_offset(retype(op[0],
> BRW_REGISTER_TYPE_UD), 1), 2));
> 

OK, thanks!

Sam

>> +      break; + case nir_op_fpow: inst =
>> bld.emit(SHADER_OPCODE_POW, result, op[0], op[1]); inst->saturate
>> = instr->dest.saturate; -- 2.5.0
>> 
>> _______________________________________________ mesa-dev mailing
>> list mesa-dev at lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKFMSAAoJEH/0ujLxfcNDkikP/R94c4gffhiF8kfyoPsy6h8W
rcO5+6RdaOB2auI2pPENwyCgqZx02bqh1+QBIamMLRis4qIvJdP2SjuCe8c2XJH4
AjGOKAxnX/SNV6pBN2F+04z1y7CRq+UwcmPe3s+imTAwD0uxNV8tbWPglj31VnBf
1mzypEDO6jqSXLEZAt+pKlLhuF6hGa5H9jEU8XHlw+dKruRWqdiMsw62Mpst9UlQ
gJML4CUfby+G8jLAJT2++V19dnmG3X2RxgnT+yMDARhzo/hfM0b1m4DVJzy5eWYD
x44u0H/8T+UCa+ktAZeKD0vVc2KggS/z6FwnkUfheKa2OlOklIQsP+PgdAv6ZbHa
Bc++XQmj/BU9fgS6NI634vun+C2okSqH36kzwXkcWRNBB6IKYmUQ7URIdG/DK4Q6
npdNweiTTnqz5L54tQXUbBFw+2qgzbWNxtHlfzL2+maOPhaLla+wl/1P4TgYx52f
PB33OjHL6dbsAIk5Lusl+27oVNxX9CXUgBil0R3s7CeMaQRsQ5S6PblBK2734Iwl
2wZkh6IQ6DVMHKged3eoWR7nob43iU4Ir4hiu93D2b4wi+lExKqmr+DOxpwHNooX
36yE6aZF7niHB64KyeJfgmPZ4yCVgajbiZ5Jy7ca24FhOkjPJGku0fLLW51dLQ+m
7J8oGPPa/GhrYbXpT2Tg
=DwZX
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list